README: Highlights our conan bintray repository#2158
Merged
mnordsletten merged 3 commits intoincludeos:devfrom May 9, 2019
Merged
README: Highlights our conan bintray repository#2158mnordsletten merged 3 commits intoincludeos:devfrom
mnordsletten merged 3 commits intoincludeos:devfrom
Conversation
MagnusS
previously requested changes
May 6, 2019
Member
MagnusS
left a comment
MagnusS
left a comment
There was a problem hiding this comment.
The > formats the text as a quote + extra space after "at". Is a word missing in the last sentence?
Contributor
Author
|
I wanted it to standout, so I put it in a quote. The sentence should look like the image below, so the URL to bintray is visible after "at" on the README as well, like Alf asked.
|
Member
|
It’s a markdown quote and may be rendered differently outside github. I think it’s fine to just add emphasis with bold, just remove the >. Last sentence lgtm |
mnordsletten
approved these changes
May 9, 2019
Contributor
mnordsletten
left a comment
mnordsletten
left a comment
There was a problem hiding this comment.
All requested changes have been implemented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.